SUBSTRATE PALLET AUDIT / Trail of Bits
Substrate vulnerability scanner
Pins the Substrate scanner's rule that a short or empty coverage table is an unfinished scan, and that ensure_signed is not a privileged origin.
“Refuses a partial Substrate pallet scan: every pattern row needs a verdict, and ensure_signed is not a privileged origin.”
01 / THE REASONING
Why this made the selection.
- A coverage table with fewer than every pattern row, or an empty verdict, must be reported as incomplete, and not having looked is not an n/a.
- The file rejects the claim that ensure_signed is enough for a privileged call and says that check fails where ensure_root is required.
02 / THE REVIEW RECORD
What we actually inspected.
Source review has boundaries.
A clear record is more useful than a “safe” badge.
Material inspected
- plugins/building-secure-contracts/skills/substrate-vulnerability-scanner/SKILL.md
- plugins/building-secure-contracts/README.md
- README.md
- LICENSE
Our findings
- Fewer than a full set of pattern rows, or an empty verdict cell, is an incomplete scan and must be reported as one.
- Not having looked is not an n/a, and a scan with no findings still has to emit the full coverage table.
- Silence is rejected because a reader cannot tell it apart from not having checked.
- Release builds wrap silently, so a clean compile is rejected as proof that arithmetic is safe.
- ensure_signed is rejected as a privileged-origin check where ensure_root belongs.
- A benchmark is rejected as proof a weight is safe when the worst case depends on storage size or an unbounded loop.
Not established by this review
- The resource was not executed.
- No pallet was scanned, fuzzed, benchmarked, or upgraded.
- resources/VULNERABILITY_PATTERNS.md was not opened.
The review applies to the material and revision named here. A newer upstream release can change its behavior.
03 / PUT IT TO WORK
Add a skill to your workflow.
DOCUMENTED COMMAND
/plugin install trailofbits/skills/plugins/building-secure-contracts Copying does not execute this command. It may retrieve a newer version than the reviewed source.
- The building-secure-contracts README shows `/plugin install trailofbits/skills/plugins/building-secure-contracts`. That installs the plugin, not this skill alone.
- The repository README shows `/plugin marketplace add trailofbits/skills`. That adds the marketplace, not this skill.
- No fetched line installs only substrate-vulnerability-scanner.
Before you start
- Claude Code, because both install lines are Claude plugin commands
- A Substrate or FRAME pallet tree to review; this review did not supply one
04 / FOLLOW THE EVIDENCE
The source trail.
Our notes are separate from the original resource.
Check upstream before adopting a new version.
https://github.com/trailofbits/skills/blob/8e54050ae63c2f62224c35b1616efe71865b4777/plugins/building-secure-contracts/skills/substrate-vulnerability-scanner/SKILL.md
Supports: Incomplete coverage tables, ensure_signed versus ensure_root, and the rejected rationalizations
https://github.com/trailofbits/skills/blob/8e54050ae63c2f62224c35b1616efe71865b4777/plugins/building-secure-contracts/README.md
Supports: Plugin install line for the building-secure-contracts plugin
- Repository README ↗Checked
https://github.com/trailofbits/skills/blob/8e54050ae63c2f62224c35b1616efe71865b4777/README.md
Supports: Marketplace install line and the CC-BY-SA-4.0 statement
- Repository LICENSE ↗Checked
https://github.com/trailofbits/skills/blob/8e54050ae63c2f62224c35b1616efe71865b4777/LICENSE
Supports: Attribution-ShareAlike 4.0 International Public License